fix: raise tree-sitter floor to 0.25, test query compilation - #2170
Merged
RaghavChamadiya merged 1 commit intoSep 11, 2026
Merged
Conversation
Aman-goel-04
requested review from
RaghavChamadiya and
swati510
as code owners
September 8, 2026 15:46
RaghavChamadiya
approved these changes
Sep 11, 2026
RaghavChamadiya
left a comment
RaghavChamadiya
left a comment
Member
There was a problem hiding this comment.
The floor bump alone would have been the easy half. Pinning tree-sitter back down to exactly 0.25.0 in its own job, with --no-sync so the pin survives, is what actually stops this regressing, and asserting on the None return rather than an exception matches what _load_compiled_query really does in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tree-sitterfloor from>=0.23,<1to>=0.25,<1. 0.23.x/0.24.x fail to compile 13 of 27 language queries (Impossible pattern), silently indexing those languages at zero symbolsNone, instead of expecting an exceptiontree-sitterto the exact declared floor (0.25.0) and runs that one test, so a future floor regression is caught without a full--resolution lowest-directjobRelated Issues
Fixes #2165
Test Plan
pytest)ruff check .)npm run build) (if frontend changes): N/A, no frontend changesChecklist